Skip to content

DEV: Add editorconfig #138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 8, 2025
Merged

DEV: Add editorconfig #138

merged 2 commits into from
Feb 8, 2025

Conversation

NeilGirdhar
Copy link
Contributor

No description provided.

Copy link
Member

@lucascolley lucascolley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think some of these rules are different to what is enforced by the linter, e.g. the max line length for py files is 88.

What is the reason for wanting this in the repo? Can we not just .gitignore it instead?

@NeilGirdhar
Copy link
Contributor Author

NeilGirdhar commented Feb 8, 2025

It makes our editors use the right settings for things like line wrap. (It should be made to match the linter's settings.)

The point of adding it is so that other people benefit from automatic settings. Otherwise, they need to look up your settings and set their editors to match.

@lucascolley lucascolley changed the title Add editorconfig DEV: Add editorconfig Feb 8, 2025
Copy link
Member

@lucascolley lucascolley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alright, LGTM when CI is happy!

@lucascolley lucascolley added the DX label Feb 8, 2025
@lucascolley lucascolley added this to the 0.6.1 milestone Feb 8, 2025
@lucascolley lucascolley merged commit a71bd2e into data-apis:main Feb 8, 2025
8 checks passed
@lucascolley
Copy link
Member

thx!

NeilGirdhar added a commit to NeilGirdhar/array-api-extra that referenced this pull request Feb 20, 2025
* Add editorconfig

* match prettier default

---------

Co-authored-by: Lucas Colley <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants